Skip to content

Fix #1240 Update chat_unfurl to support source/unfurl_id parameters#1241

Merged
seratch merged 2 commits intoslackapi:mainfrom
seratch:issue-1240-chat-unfurl
Jul 19, 2022
Merged

Fix #1240 Update chat_unfurl to support source/unfurl_id parameters#1241
seratch merged 2 commits intoslackapi:mainfrom
seratch:issue-1240-chat-unfurl

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Jul 19, 2022

Summary

This pull request resolves #1240

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Jul 19, 2022
@seratch seratch added this to the 3.18.0 milestone Jul 19, 2022
@seratch seratch self-assigned this Jul 19, 2022
srajiang
srajiang approved these changes Jul 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seratch! :)

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1241 (5e533d3) into main (e4ccb13) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
- Coverage   86.62%   86.61%   -0.01%     
==========================================
  Files         111      111              
  Lines       11026    11026              
==========================================
- Hits         9551     9550       -1     
- Misses       1475     1476       +1
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 85.14% <ø> (ø)
slack_sdk/web/client.py 86.52% <ø> (ø)
slack_sdk/web/legacy_client.py 86.24% <ø> (ø)
slack_sdk/socket_mode/builtin/internals.py 74.12% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ccb13...5e533d3. Read the comment docs.

@seratch seratch merged commit 5ae7089 into slackapi:main Jul 19, 2022
@seratch seratch deleted the issue-1240-chat-unfurl branch July 19, 2022 01:52
@angrychimp
Copy link
Copy Markdown

angrychimp commented Jul 19, 2022

Thank you for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@srajiang srajiang srajiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client

Projects

None yet

Milestone

3.18.0

Development

Successfully merging this pull request may close these issues.

Update chat_unfurl to support source/unfurl_id parameters

3 participants

@seratch @angrychimp @srajiang