Skip to content

Fix #1236 Add video block to Block Kit model classes#1237

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-1236-video-blocks
Jul 15, 2022
Merged

Fix #1236 Add video block to Block Kit model classes#1237
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-1236-video-blocks

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Jul 15, 2022

Summary

This pull request resolves #1236

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Jul 15, 2022
@seratch seratch added this to the 3.18.0 milestone Jul 15, 2022
@seratch seratch self-assigned this Jul 15, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1237 (dd2db0e) into main (5d509e0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   86.56%   86.60%   +0.03%     
==========================================
  Files         111      111              
  Lines       10986    11026      +40     
==========================================
+ Hits         9510     9549      +39     
- Misses       1476     1477       +1
Impacted Files Coverage Δ
slack_sdk/models/blocks/__init__.py 100.00% <100.00%> (ø)
slack_sdk/models/blocks/blocks.py 96.83% <100.00%> (+0.57%) ⬆️
slack_sdk/socket_mode/builtin/internals.py 73.68% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d509e0...dd2db0e. Read the comment docs.

filmaj
filmaj approved these changes Jul 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seratch seratch merged commit e4ccb13 into slackapi:main Jul 15, 2022
@seratch seratch deleted the issue-1236-video-blocks branch July 15, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilliamBergamin WilliamBergamin Awaiting requested review from WilliamBergamin

1 more reviewer

@filmaj filmaj filmaj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality Version: 3x web-client

Projects

None yet

Milestone

3.18.0

Development

Successfully merging this pull request may close these issues.

Add video block to Block Kit model classes

2 participants

@seratch @filmaj