Skip to content

Fix wrong type annotation#1235

Merged
seratch merged 2 commits intoslackapi:mainfrom
ehdgua01:main
Jul 12, 2022
Merged

Fix wrong type annotation#1235
seratch merged 2 commits intoslackapi:mainfrom
ehdgua01:main

Conversation

@ehdgua01
Copy link
Copy Markdown
Contributor

@ehdgua01 ehdgua01 commented Jul 12, 2022 •
edited
Loading

Summary

Title is description

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch self-assigned this Jul 12, 2022
@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Jul 12, 2022
@seratch seratch added this to the 3.17.3 milestone Jul 12, 2022
seratch
seratch approved these changes Jul 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 12, 2022 •
edited
Loading

Codecov Report

Merging #1235 (a426241) into main (40c50c9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         111      111           
  Lines       10986    10986           
=======================================
  Hits         9510     9510           
  Misses       1476     1476
Impacted Files Coverage Δ
slack_sdk/models/blocks/block_elements.py 92.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c50c9...a426241. Read the comment docs.

@seratch seratch merged commit 5d509e0 into slackapi:main Jul 12, 2022
@seratch seratch modified the milestones: 3.17.3, 3.18.0 Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@seratch seratch seratch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality Version: 3x web-client

Projects

None yet

Milestone

3.18.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ehdgua01 @seratch