Conversation
Codecov Report
@@ Coverage Diff @@
## main #1225 +/- ##
=======================================
Coverage 86.54% 86.54%
=======================================
Files 111 111
Lines 10943 10943
=======================================
Hits 9471 9471
Misses 1472 1472 Continue to review full report at Codecov.
|
seratch
approved these changes
Jun 10, 2022
Contributor
seratch
left a comment
There was a problem hiding this comment.
Thanks for updating this! Once you resolves my comments, you can merge this PR (don't forget squashing commits into one!)
filmaj
suggested changes
Jun 10, 2022
Contributor
filmaj
left a comment
There was a problem hiding this comment.
Looks pretty good to me, left a couple of comments just to clarify a few final things. Thanks for improving this!
merge away!
seratch
approved these changes
Jun 13, 2022
Contributor
seratch
left a comment
There was a problem hiding this comment.
LGTM - thanks for updating this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the maintainers guide, this should help developer more clearly understand how to build the project and run the tests. This should also help push the project towards using a bash approach to building and running the test as implemented in the bolt python project.
What was done:
python setup.pycommands with their corresponding bash script commandsCategory (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.