Improve the installation data queries to always return the latest bot token#1223
Merged
seratch merged 1 commit intoslackapi:mainfrom Jun 13, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1223 +/- ##
==========================================
- Coverage 86.54% 86.54% -0.01%
==========================================
Files 111 111
Lines 10943 10986 +43
==========================================
+ Hits 9471 9508 +37
- Misses 1472 1478 +6
Continue to review full report at Codecov.
|
b8f9b71 to
334ba14
Compare
morningcloud
added a commit
to morningcloud/slack_installation_store
that referenced
this pull request
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves the issue described at slackapi/bolt-python#664 for the built-in installation stores. Refer to the issue for the details.
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.