Skip to content

Use 125 chars for max line length for both flake8 and black#1221

Merged
seratch merged 2 commits intoslackapi:mainfrom
seratch:black-flake8-consistency
May 31, 2022
Merged

Use 125 chars for max line length for both flake8 and black#1221
seratch merged 2 commits intoslackapi:mainfrom
seratch:black-flake8-consistency

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented May 30, 2022

Summary

This pull request makes the black code formatter configuration to be consistent with flake8. See slackapi/bolt-python#662 for the context.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added this to the 3.17.1 milestone May 30, 2022
@seratch seratch self-assigned this May 30, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2022 •
edited
Loading

Codecov Report

Merging #1221 (dc6fea5) into main (bd14d32) will increase coverage by 0.03%.
The diff coverage is 77.41%.

❗ Current head dc6fea5 differs from pull request most recent head 8dd4549. Consider uploading reports for the commit 8dd4549 to get more accurate results

@@            Coverage Diff             @@
##             main    #1221      +/-   ##
==========================================
+ Coverage   86.54%   86.58%   +0.03%     
==========================================
  Files         111      111              
  Lines       10943    10943              
==========================================
+ Hits         9471     9475       +4     
+ Misses       1472     1468       -4
Impacted Files Coverage Δ
slack_sdk/models/__init__.py 100.00% <ø> (ø)
...uth/installation_store/async_installation_store.py 60.86% <0.00%> (ø)
slack_sdk/socket_mode/request.py 72.72% <0.00%> (ø)
slack_sdk/web/legacy_slack_response.py 90.90% <16.66%> (ø)
slack_sdk/rtm_v2/__init__.py 51.88% <20.00%> (ø)
slack_sdk/models/messages/message.py 68.75% <25.00%> (ø)
...dk/oauth/installation_store/models/installation.py 89.89% <25.00%> (ø)
slack_sdk/web/async_slack_response.py 90.47% <28.57%> (ø)
slack_sdk/oauth/token_rotation/async_rotator.py 74.54% <33.33%> (ø)
slack_sdk/socket_mode/builtin/connection.py 64.44% <37.50%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd14d32...8dd4549. Read the comment docs.

@seratch seratch force-pushed the black-flake8-consistency branch from dc6fea5 to 8dd4549 Compare May 31, 2022 01:19
@seratch seratch merged commit c9dc6aa into slackapi:main May 31, 2022
@seratch seratch deleted the black-flake8-consistency branch May 31, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@seratch seratch

Labels

audit-logs-client oauth rtm-client scim-client socket-mode tests M-T: Testing work only Version: 3x web-client

Projects

None yet

Milestone

3.17.1

Development

Successfully merging this pull request may close these issues.

1 participant

@seratch