Fix #1218 - Reduce minimum number of overflow options#1219
Merged
seratch merged 1 commit intoslackapi:mainfrom May 25, 2022
Merged
Fix #1218 - Reduce minimum number of overflow options#1219seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
misscoded
commented
May 25, 2022
| Maximum length for this field is 255 characters. | ||
| options (required): An array of option objects to display in the menu. | ||
| Maximum number of options is 5, minimum is 2. | ||
| Maximum number of options is 5, minimum is 1. |
Contributor
Author
There was a problem hiding this comment.
@seratch I ran both of the documentation steps and it resulted in a ton of changes. Happy to include those here, but wanted to be sure before I pushed them all up.
Contributor
There was a problem hiding this comment.
@misscoded Thanks for checking that! More fixes would be appreciated 👍
Codecov Report
@@ Coverage Diff @@
## main #1219 +/- ##
=======================================
Coverage 86.58% 86.58%
=======================================
Files 111 111
Lines 10943 10943
=======================================
Hits 9475 9475
Misses 1468 1468
Continue to review full report at Codecov.
|
seratch
approved these changes
May 25, 2022
Contributor
|
Thanks for fixing this issue! Let me merge this one as the first step now. |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1218.
Though API documentation says a minimum of two options are required for the
overflowmenu, one is acceptable and works without issue. This PR updates the SDK's minimum number to match that.Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.