Skip to content

Adding the auth_teams_list method#1213

Merged
seratch merged 2 commits intomainfrom
add-auth_teams_list
May 18, 2022
Merged

Adding the auth_teams_list method#1213
seratch merged 2 commits intomainfrom
add-auth_teams_list

Conversation

@filmaj
Copy link
Copy Markdown
Contributor

@filmaj filmaj commented May 18, 2022

Summary

This fixes #1212.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@filmaj filmaj added enhancement M-T: A feature request for new functionality semver:minor web-client area:async labels May 18, 2022
@filmaj filmaj added this to the 3.17.0 milestone May 18, 2022
@filmaj filmaj requested a review from seratch May 18, 2022 21:55
@filmaj filmaj self-assigned this May 18, 2022
seratch
seratch suggested changes May 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been adding all the optional args to the keyword arguments since this PR #1099

Can you add the three listed here? https://api.slack.com/methods/auth.teams.list

@codecov
Copy link
Copy Markdown

codecov bot commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #1213 (6fa1a80) into main (e4df183) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   86.54%   86.58%   +0.03%     
==========================================
  Files         111      111              
  Lines       10934    10943       +9     
==========================================
+ Hits         9463     9475      +12     
+ Misses       1471     1468       -3
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 85.14% <100.00%> (+0.04%) ⬆️
slack_sdk/web/client.py 86.52% <100.00%> (+0.04%) ⬆️
slack_sdk/web/legacy_client.py 86.24% <100.00%> (+0.04%) ⬆️
slack_sdk/socket_mode/builtin/internals.py 72.36% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4df183...6fa1a80. Read the comment docs.

@filmaj
Copy link
Copy Markdown
Contributor Author

filmaj commented May 18, 2022

@seratch ah yes my bad, adding now.

@filmaj filmaj force-pushed the add-auth_teams_list branch from 594476d to 3529649 Compare May 18, 2022 22:08
@filmaj filmaj requested a review from seratch May 18, 2022 22:09
seratch
seratch reviewed May 18, 2022
View reviewed changes
@seratch seratch merged commit da8c0a1 into main May 18, 2022
@seratch seratch deleted the add-auth_teams_list branch May 18, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@seratch seratch seratch requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@filmaj filmaj

Labels

area:async enhancement M-T: A feature request for new functionality semver:minor web-client

Projects

None yet

Milestone

3.17.0

Development

Successfully merging this pull request may close these issues.

auth.teams.list API method is not supported in WebClient

2 participants

@filmaj @seratch