Skip to content

Fix #1184 Add exception handling for socket mode - BlockingIOError: Resource temporarily unavailable#1185

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-1184
Feb 19, 2022
Merged

Fix #1184 Add exception handling for socket mode - BlockingIOError: Resource temporarily unavailable#1185
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-1184

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Feb 19, 2022

Summary

This pull request fixes #1184 . Also, it changes other internal methods in the same way. As for the built-in internal modules, there is less benefit by displaying full stacktrace.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality Version: 3x socket-mode labels Feb 19, 2022
@seratch seratch added this to the 3.15.1 milestone Feb 19, 2022
@seratch seratch self-assigned this Feb 19, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2022

Codecov Report

Merging #1185 (0604f46) into main (eec08f4) will decrease coverage by 0.14%.
The diff coverage is 10.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
- Coverage   86.69%   86.54%   -0.15%     
==========================================
  Files         110      110              
  Lines       10834    10855      +21     
==========================================
+ Hits         9393     9395       +2     
- Misses       1441     1460      +19
Impacted Files Coverage Δ
slack_sdk/socket_mode/builtin/connection.py 64.44% <0.00%> (-3.80%) ⬇️
slack_sdk/socket_mode/builtin/client.py 89.63% <37.50%> (-2.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec08f4...0604f46. Read the comment docs.

@seratch seratch merged commit 9d9a6e1 into slackapi:main Feb 19, 2022
@seratch seratch deleted the issue-1184 branch February 19, 2022 01:10
@seratch seratch mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality socket-mode Version: 3x

Projects

None yet

Milestone

3.15.1

Development

Successfully merging this pull request may close these issues.

Add exception handling for socket mode - BlockingIOError: Resource temporarily unavailable

1 participant

@seratch