Pass ssl_context from the web_client to the websocket#1177
Merged
seratch merged 1 commit intoslackapi:mainfrom Feb 16, 2022
Merged
Pass ssl_context from the web_client to the websocket#1177seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
+ Coverage 86.62% 86.63% +0.01%
==========================================
Files 110 110
Lines 10789 10793 +4
==========================================
+ Hits 9346 9351 +5
+ Misses 1443 1442 -1
Continue to review full report at Codecov.
|
seratch
approved these changes
Feb 16, 2022
Contributor
seratch
left a comment
There was a problem hiding this comment.
Perfect, looks great to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR should fix this bug: #1175
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.