Fix a bug where some of the files.remote API parameters do not work since v3.10#1173
Merged
seratch merged 1 commit intoslackapi:mainfrom Feb 8, 2022
Merged
Fix a bug where some of the files.remote API parameters do not work since v3.10#1173seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1173 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 110 110
Lines 10780 10780
=======================================
Hits 9338 9338
Misses 1442 1442
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves a bug on files.remote.* API support that affects v3.10, 3.11, 3.12, 3.13, 3.14 users. When we added all the optional parameter support in v3.10, the changes caused a regression bug on those API methods: #1099
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.