Skip to content

Stop raising asyncio.CancelledError if the connection is already closed#1152

Merged
seratch merged 3 commits intoslackapi:mainfrom
mattvonarx:patch-1
Jan 21, 2022
Merged

Stop raising asyncio.CancelledError if the connection is already closed#1152
seratch merged 3 commits intoslackapi:mainfrom
mattvonarx:patch-1

Conversation

@mattvonarx
Copy link
Copy Markdown
Contributor

@mattvonarx mattvonarx commented Dec 13, 2021

Summary

There are now noisy log messages when closing a connection.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@srajiang
Copy link
Copy Markdown
Contributor

srajiang commented Dec 13, 2021

Hi @VectorAlpha - Thanks for submitting this contribution!
Would you please sign the contributor license agreement?

@srajiang srajiang requested review from seratch and srajiang December 13, 2021 17:27
@seratch
Copy link
Copy Markdown
Contributor

seratch commented Dec 14, 2021

Hi @VectorAlpha, can I ask you to provide a bit more details of the verbose logging that you've encountered?

@seratch seratch added needs info An issue that is claimed to be a bug and hasn't been reproduced, or otherwise needs more info socket-mode Version: 3x labels Dec 14, 2021
@seratch seratch self-assigned this Dec 14, 2021
seratch
seratch suggested changes Jan 12, 2022
View reviewed changes
@seratch seratch changed the title Update async_client.py Stop raising asyncio.CancelledError if the connection is already closed Jan 21, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2022

Codecov Report

Merging #1152 (73593cb) into main (2dee665) will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   86.67%   86.61%   -0.07%     
==========================================
  Files         110      110              
  Lines       10771    10774       +3     
==========================================
- Hits         9336     9332       -4     
- Misses       1435     1442       +7
Impacted Files Coverage Δ
slack_sdk/socket_mode/async_client.py 72.50% <66.66%> (-4.43%) ⬇️
slack_sdk/socket_mode/builtin/internals.py 72.00% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dee665...73593cb. Read the comment docs.

@seratch seratch removed the needs info An issue that is claimed to be a bug and hasn't been reproduced, or otherwise needs more info label Jan 21, 2022
@seratch seratch added this to the 3.14.0 milestone Jan 21, 2022
@seratch seratch merged commit afa40ea into slackapi:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srajiang srajiang Awaiting requested review from srajiang

1 more reviewer

@seratch seratch seratch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

socket-mode Version: 3x

Projects

None yet

Milestone

3.14.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mattvonarx @CLAassistant @srajiang @seratch