Skip to content

Fix #1131 Add the method to check equality in Block Kit model classes#1137

Merged
seratch merged 4 commits intoslackapi:mainfrom
horn553:main
Nov 24, 2021
Merged

Fix #1131 Add the method to check equality in Block Kit model classes#1137
seratch merged 4 commits intoslackapi:mainfrom
horn553:main

Conversation

@horn553
Copy link
Copy Markdown
Contributor

@horn553 horn553 commented Nov 22, 2021 •
edited by seratch
Loading

Summary

Fixes #1131

@seratch
Sorry for the delay.
I worked on the issue #1131.

I've confirmed the following.

  • Passing Unit Tests
  • Solving the problem in interactive mode

Thank you for checking!

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

seratch
seratch suggested changes Nov 22, 2021
View reviewed changes
@seratch seratch added this to the 3.12.0 milestone Nov 22, 2021
@seratch seratch added enhancement M-T: A feature request for new functionality Version: 3x web-client labels Nov 22, 2021
@seratch seratch self-assigned this Nov 22, 2021
@seratch seratch changed the title Add __eq__ method to slack_sdk.models.JsonObject (#1131) Fix #1131 Add the method to check equality in Block Kit model classes Nov 22, 2021
@horn553 horn553 marked this pull request as draft November 24, 2021 06:40
@horn553 horn553 marked this pull request as ready for review November 24, 2021 07:32
@horn553 horn553 requested a review from seratch November 24, 2021 07:32
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2021

Codecov Report

Merging #1137 (baf593d) into main (6c46f32) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
- Coverage   86.57%   86.57%   -0.01%     
==========================================
  Files         110      110              
  Lines       10750    10754       +4     
==========================================
+ Hits         9307     9310       +3     
- Misses       1443     1444       +1
Impacted Files Coverage Δ
slack_sdk/models/basic_objects.py 89.83% <75.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c46f32...baf593d. Read the comment docs.

@seratch seratch merged commit 07d1dbf into slackapi:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@seratch seratch seratch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality Version: 3x web-client

Projects

None yet

Milestone

3.12.0

Development

Successfully merging this pull request may close these issues.

Add the method to check equality in Block Kit model classes

3 participants

@horn553 @CLAassistant @seratch