Skip to content

Update the entity name to Slack Technologies, LLC#1105

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:llc
Aug 25, 2021
Merged

Update the entity name to Slack Technologies, LLC#1105
seratch merged 1 commit intoslackapi:mainfrom
seratch:llc

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Aug 25, 2021

Summary

This pull request updates the entity name from "Slack Technologies, Inc." to "Slack Technologies, LLC"

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added Version: 2x docs M-T: Documentation work only Version: 3x labels Aug 25, 2021
@seratch seratch added this to the 3.10.0 milestone Aug 25, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 25, 2021

Codecov Report

Merging #1105 (b24f597) into main (fada5dc) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
+ Coverage   86.27%   86.29%   +0.01%     
==========================================
  Files         110      110              
  Lines       10413    10413              
==========================================
+ Hits         8984     8986       +2     
+ Misses       1429     1427       -2
Impacted Files Coverage Δ
slack_sdk/socket_mode/builtin/connection.py 36.13% <0.00%> (+0.42%) ⬆️
slack_sdk/socket_mode/builtin/client.py 79.86% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fada5dc...b24f597. Read the comment docs.

misscoded
misscoded reviewed Aug 25, 2021
View reviewed changes
LICENSE
The MIT License (MIT)

Copyright (c) 2015-2016 Slack Technologies, Inc
Copyright (c) 2015- Slack Technologies, LLC
Copy link
Copy Markdown
Contributor

@misscoded misscoded Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a recent message from legal recommending that the copyright year be 2021 in a similar context. Is it OK to keep it open-ended as we have here?

Copy link
Copy Markdown
Contributor Author

@seratch seratch Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will check.

Copy link
Copy Markdown
Contributor Author

@seratch seratch Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Just having the original date with the latest entity is appropriate here. No update is needed.

misscoded
misscoded approved these changes Aug 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing that gave me pause is the inclusion of "and contributors", but other than that, LGTM!

@seratch seratch merged commit 1c53d7f into slackapi:main Aug 25, 2021
@seratch seratch deleted the llc branch August 25, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@misscoded misscoded misscoded approved these changes

@srajiang srajiang Awaiting requested review from srajiang

+1 more reviewer

@filmaj filmaj filmaj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs M-T: Documentation work only Version: 2x Version: 3x

Projects

None yet

Milestone

3.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@seratch @mwbrooks @filmaj @misscoded