Fix #1102 Add __contains__ method in slack_sdk.web.SlackResponse / AsyncSlackResponse#1104
Merged
seratch merged 1 commit intoslackapi:mainfrom Aug 20, 2021
Merged
Conversation
…nse / AsyncSlackResponse
Codecov Report
@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
+ Coverage 86.16% 86.18% +0.02%
==========================================
Files 110 110
Lines 9951 9955 +4
==========================================
+ Hits 8574 8580 +6
+ Misses 1377 1375 -2
Continue to review full report at Codecov.
|
seratch
commented
Aug 20, 2021
| @@ -1,6 +1,6 @@ | |||
| import unittest | |||
|
|
|||
| from slack.web.async_slack_response import AsyncSlackResponse | |||
Contributor
Author
There was a problem hiding this comment.
This import had been just wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #1102. Refer to the issue for details.
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./docs.sh?)/docs-src-v2(Documents, have you run./docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.