Skip to content

Update command in maintainers guide#1048

Merged
seratch merged 1 commit intoslackapi:mainfrom
srajiang:sj_fix_readme
Jun 24, 2021
Merged

Update command in maintainers guide#1048
seratch merged 1 commit intoslackapi:mainfrom
srajiang:sj_fix_readme

Conversation

@srajiang
Copy link
Copy Markdown
Contributor

Summary

Updates with command to run integration_tests based on setup.py line 319.

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@gitwave gitwave bot added the untriaged label Jun 24, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2021

Codecov Report

Merging #1048 (b29ba81) into main (148fbb1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files          95       95           
  Lines        8938     8938           
=======================================
  Hits         7538     7538           
  Misses       1400     1400           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148fbb1...b29ba81. Read the comment docs.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented tests M-T: Testing work only Version: 3x and removed untriaged labels Jun 24, 2021
@seratch seratch added this to the 3.8.0 milestone Jun 24, 2021
Copy link
Copy Markdown
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seratch seratch merged commit a087d71 into slackapi:main Jun 24, 2021
@srajiang srajiang deleted the sj_fix_readme branch August 9, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented tests M-T: Testing work only Version: 3x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants