add use-sudo optional parameter defaulting to false. Fixes: #85#84
add use-sudo optional parameter defaulting to false. Fixes: #85#84cpanato merged 1 commit intosigstore:mainfrom
Conversation
ac30cae to
2fe9b69
Compare
cpanato
left a comment
There was a problem hiding this comment.
thanks for the PR, just a minor comments
|
The one failing test failed for |
kind of, because that to install the lib it needs the in this part: https://github.com/sigstore/cosign-installer/blob/main/action.yml#L208-L223 |
Yep ok, I'll fix this. I should have paid more attention to this failure, sorry about that. |
Signed-off-by: Jason Solis <jsolis@gmail.com>
|
OK, I can see from before the |
Summary
Adds optional input
use-sudothat can be set totruein the case thatinstall-dirrequires sudo privs. The reason for this is that always usingsudoactually broke ourself-hostedrunners since the user the runner runs as doesn't have sudo privs by security design.Ticket Link
Fixes #85
Release Note