Merged
Conversation
cpanato
requested changes
Feb 1, 2022
Member
|
@jauderho please sign the DCO :) |
Signed-off-by: Carlos Panato <ctadeu@gmail.com> Signed-off-by: Jauder Ho <jauderho@users.noreply.github.com>
Make sure that all actions are using commit hashes. Signed-off-by: Jauder Ho <jauderho@users.noreply.github.com>
Match L224 and L246. Use - uses: actions/checkout@ec3a7ce #v2.4.0 Signed-off-by: Jauder Ho <jauderho@users.noreply.github.com>
Contributor
Author
|
Done |
Member
|
@jauderho thanks for updating the ci and I see now you updated the action itself, can you please update both PR title and summary to reflect that? I would say if you can split into two PRs will be better |
Member
|
just remember now the cosign was already updated in this pr #53 |
Contributor
Author
|
@cpanato I think it is because I had not yet pulled in your changes into my branch. I have now done so and if you look again, it's once again just the test-action.yaml change again. |
cpanato
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make sure that all actions are using commit hashes.
Ticket Link
Fixes
Make sure that all actions are using commit hashes.
Release Note
Signed-off-by: Jauder Ho jauderho@users.noreply.github.com