Skip to content

Optimized .ShouldBeUnique() for large datasets#603

Merged
josephwoodward merged 1 commit intoshouldly:masterfrom
JakenVeina:ShouldBeUnique-Performance
Jun 1, 2020
Merged

Optimized .ShouldBeUnique() for large datasets#603
josephwoodward merged 1 commit intoshouldly:masterfrom
JakenVeina:ShouldBeUnique-Performance

Conversation

@JakenVeina
Copy link
Copy Markdown
Contributor

With corresponding test.

Resolves #602.

@josephwoodward
Copy link
Copy Markdown
Contributor

Oh nice, thanks for this!

@JakenVeina
Copy link
Copy Markdown
Contributor Author

Not a problem. Not sure why the build is failing, but I'm fairly certain it's not related to the changes. It definitely builds and tests fine locally.

@josephwoodward josephwoodward merged commit 9f5e0a1 into shouldly:master Jun 1, 2020
@SimonCropp SimonCropp added this to the 4.0.0 milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.ShouldBeUnique() runs in O(n!) time

3 participants