fix: resolve issue with xdebug.mode not being set#346
Closed
owenvoke wants to merge 1 commit intoshivammathur:developfrom
Closed
fix: resolve issue with xdebug.mode not being set#346owenvoke wants to merge 1 commit intoshivammathur:developfrom
owenvoke wants to merge 1 commit intoshivammathur:developfrom
Conversation
Contributor
Author
|
Just noticed you've already committed changes to this effect. 👍🏻 fce77af Thanks @shivammathur for all your work on this. |
Owner
|
@owenvoke Thanks for testing this, fix will be in next release shortly. |
Merged
Owner
|
@owenvoke Merged in |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related discussion: pestphp/pest#226
Description
When using
coverage: xdebugon macOS and Windows (Linux correctly uses Xdebug 2 for now on PHP<=7.4), it appears to fail on PHP 7.x as Xdebug 3 is being installed, rather than Xdebug 2.x. As this bit of code is expecting forcoverage: xdebug3or PHP 8 to add thexdebug.mode=coverageline, this never gets set.I've created some workflows that tested against all PHP versions back to 5.3, and their compatible PHPUnit version.
On the current version, PHPUnit flags a warning that
xdebug.mode=coverage has to be set in php.ini. I'm also not sure whyXDEBUG_CC_UNUSEDis undefined on PHP 7.2 for macOS and Windows.npm run formatbefore the commit.npm run lintbefore the commit.npm run releasebefore the commit.npm testreturns with no unit test errors and all code covered.