Skip to content

2.6.0#300

Merged
shivammathur merged 14 commits intomasterfrom
develop
Oct 5, 2020
Merged

2.6.0#300
shivammathur merged 14 commits intomasterfrom
develop

Conversation

@shivammathur
Copy link
Copy Markdown
Owner

@shivammathur shivammathur commented Oct 5, 2020

  • Setup PHP now has discussions feature. So if you need any help with your workflows, want to suggest features or share anything in general related to PHP, please use setup-php discussions.
  • Add support for behat and phpspec. (Docs)
- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
    php-version: '7.4'
    tools: behat, phpspec
- name: Setup PHP with phing
  uses: shivammathur/setup-php@v2
  with:
    php-version: latest

Thanks @szepeviktor for the contributions 🎉

@shivammathur shivammathur added release security Pull requests that address a security vulnerability labels Oct 5, 2020
@shivammathur shivammathur self-assigned this Oct 5, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 5, 2020

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #300   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         5    -1     
  Lines          476       486   +10     
=========================================
+ Hits           476       486   +10     
Impacted Files Coverage Δ
src/tools.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f0cfca...6acafbc. Read the comment docs.

@shivammathur shivammathur merged commit 17f319a into master Oct 5, 2020
shivammathur added a commit that referenced this pull request Oct 15, 2020
shivammathur added a commit that referenced this pull request Oct 15, 2020
Kingdutch added a commit to Kingdutch/graphql-php that referenced this pull request Nov 27, 2020
`set-env` and `add-path` are disabled in GitHub actions. 
See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

This requires an update to the action using those
commands. This means at least version 2.6.0 is
needed. See shivammathur/setup-php#300

However there seem to be no breaking changes so we
can go straight to 2.9.0 instead. This also allows testing
with version 8.x of PHP.
simPod pushed a commit to webonyx/graphql-php that referenced this pull request Nov 27, 2020
`set-env` and `add-path` are disabled in GitHub actions. 
See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

This requires an update to the action using those
commands. This means at least version 2.6.0 is
needed. See shivammathur/setup-php#300

However there seem to be no breaking changes so we
can go straight to 2.9.0 instead. This also allows testing
with version 8.x of PHP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release security Pull requests that address a security vulnerability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

global env overrides local with Add support for PHP version "latest" report versions of the used tools

2 participants