Merged
Conversation
NYC takes forever on my local machine, and I generally prefer to look at coverage reports on the website anyway. This changes `npm test` to run without coverage, and changes our CI to run `npm run test-with-coverage` instead.
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 34 34
Lines 1271 1271
=======================================
Hits 1237 1237
Misses 34 34Continue to review full report at Codecov.
|
nfischer
added a commit
that referenced
this pull request
Jan 4, 2019
This adds initial support for long options. This integration tests them with `shell.touch()` and unit tests them in `test/common.js`. This also refactors some of the common internals: * Creates a new CommandError type to replace the `'earlyExit'` hack * Clearer Error types for `parseOptions()` exceptions * Removes side effects from a test which modifies `common.config` * Fixes appveyor and travis config to run lint (regressed in #920) Issue #924 Test: touch.js, common.js
nfischer
added a commit
that referenced
this pull request
Jan 4, 2019
This adds initial support for long options. This integration tests them with `shell.touch()` and unit tests them in `test/common.js`. This documents the new syntax. This also refactors some of the common internals: * Creates a new CommandError type to replace the `'earlyExit'` hack * Clearer Error types for `parseOptions()` exceptions * Removes side effects from a test which modifies `common.config` * Fixes appveyor and travis config to run lint (regressed in #920) Issue #924 Test: touch.js, common.js
nfischer
added a commit
that referenced
this pull request
Jan 5, 2019
* feat(options): initial support for long options This adds initial support for long options. This integration tests them with `shell.touch()` and unit tests them in `test/common.js`. This documents the new syntax. This also refactors some of the common internals: * Creates a new CommandError type to replace the `'earlyExit'` hack * Clearer Error types for `parseOptions()` exceptions * Removes side effects from a test which modifies `common.config` * Fixes appveyor and travis config to run lint (regressed in #920) Issue #924 Test: touch.js, common.js * small refactor for errorOptions
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NYC takes forever on my local machine, and I generally prefer to look at
coverage reports on the website anyway.
This changes
npm testto run without coverage, and changes our CI torun
npm run test-with-coverageinstead.