Skip to content

Add all CSS length units in known compatibilities#1868

Merged
nex3 merged 1 commit intosass:mainfrom
stof:patch-1
Jan 30, 2023
Merged

Add all CSS length units in known compatibilities#1868
nex3 merged 1 commit intosass:mainfrom
stof:patch-1

Conversation

@stof
Copy link
Copy Markdown
Contributor

@stof stof commented Jan 11, 2023

This allows more validation of wrong computations in first-class calc.

This adds the missing font-relative and viewport-relative units from https://drafts.csswg.org/css-values-4/#font-relative-lengths

@nex3 nex3 self-requested a review January 17, 2023 21:26
@nex3
Copy link
Copy Markdown
Contributor

nex3 commented Jan 17, 2023

Which of these are actually implemented in a real browser? That's our metric for whether to add support for a new feature in the spec.

@stof
Copy link
Copy Markdown
Contributor Author

stof commented Jan 18, 2023

Based on https://developer.mozilla.org/en-US/docs/Web/CSS/length#browser_compatibility, only rlh is not yet implemented (but based on https://bugs.webkit.org/show_bug.cgi?id=246522, it is implemented in Safari TP so will probably be there in the next Safari release). And cap is implemented only in Firefox for now.
And looking at that list, I forgot the container query units (which are defined in a different CSS module but have cross-browser support)

@stof
Copy link
Copy Markdown
Contributor Author

stof commented Jan 18, 2023

And https://bugs.chromium.org/p/chromium/issues/detail?id=1381037 marks rlh (and a few other r* units) as implemented in Chromium 2 days ago.

@nex3
Copy link
Copy Markdown
Contributor

nex3 commented Jan 24, 2023

Sounds good. Can you add a changelog entry as well?

@stof
Add all CSS length units in known compatibilities
31d450e 
This allows more validation of wrong computations in first-class calc.
@stof
Copy link
Copy Markdown
Contributor Author

stof commented Jan 25, 2023

@nex3 done.

@nex3 nex3 merged commit 5a521b8 into sass:main Jan 30, 2023
@stof stof deleted the patch-1 branch January 31, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nex3 nex3 nex3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stof @nex3