Revert back to winapi dependency for v0.4#340
Merged
Conversation
As noted in <rust-lang#308>, switching from winapi to windows-sys was a breaking change as we expose some of the winapi types that are different in windows-sys. This reverts the following commits: * "Relax windows-sys dependency version" 81056b9. * "Support Socket::(set_)recv_tos on Windows" 242e087. * "Replace winapi with windows-sys" aeb6c2d. We'll make this switch in v0.5 instead.
Merged
Darksonn
approved these changes
Aug 26, 2022
Darksonn
left a comment
Member
There was a problem hiding this comment.
LGTM, but wasn't this already reverted?
Collaborator
Author
No, we just yanked the v0.4.5 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #308, switching
from winapi to windows-sys was a breaking change as we expose some of
the winapi types that are different in windows-sys.
This reverts the following commits:
We'll make this switch in v0.5 instead.