Skip to content

[patch] improve performance#44

Merged
rs merged 1 commit intors:masterfrom
kpango:feature-improve-performance
Mar 18, 2019
Merged

[patch] improve performance#44
rs merged 1 commit intors:masterfrom
kpango:feature-improve-performance

Conversation

@kpango
Copy link
Copy Markdown

@kpango kpango commented Mar 18, 2019

Hi, I patched 2 fixes for performance improvement.

  1. It is possible to skip the subsequent boundary value check by accessing from the end of the slice, so I changed it. ( https://go101.org/article/bounds-check-elimination.html#slice-comparison )
  2. zero copy casting like strings.Builder. ( https://golang.org/src/strings/builder.go?s=1416:1457#L36 )

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@rs rs merged commit cc5ec57 into rs:master Mar 18, 2019
@kpango kpango deleted the feature-improve-performance branch March 18, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants