Add Ruby 3.1 to the CI matrix#89
Merged
Conversation
kou
reviewed
Mar 8, 2022
| require "minitest" | ||
| require "rr" | ||
| when "minitest-active-support" | ||
| require "active_support" |
Member
There was a problem hiding this comment.
Could you show the error message without this?
Contributor
Author
There was a problem hiding this comment.
Here you go. I've run into this several times now when adding Rails 7 support to gems.
Rails repo discussion is here - rails/rails#43851
My fork error is here - https://github.com/petergoldstein/rr/runs/5472214118?check_suite_focus=true
Screenshot:
Member
There was a problem hiding this comment.
Thanks.
Can we remove require "active_support/test_case"?
Contributor
Author
There was a problem hiding this comment.
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to adding 3.1 to the list of tested Rubies, this PR fixes a class loading issue in the integration tests. This class loading issue appeared because ActiveSupport 7.0 is now being pulled in for these specs.