Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#more-repl-optionsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4824 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 219 219
Lines 7826 7826
Branches 2169 2169
=======================================
Hits 7747 7747
Misses 26 26
Partials 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
262a8e0 to
de5dede
Compare
✅ Deploy Preview for rollupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
1c7ba8f to
6d5dd94
Compare
Collaborator
|
This PR has been released as part of rollup@3.11.0. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This will add nearly all remaining options to the REPL. Basically, all options are supported that can be mapped as a selection from a given list of values, a single free-text field, or a mapping of a given list of strings to new strings (like the
globalsoption).To that end, there is a new "add option" button to the bottom left of the options panel to add additional lines. Options that cannot be used due to a combination of other selected options or properties of the current modules are hidden. E.g.
preserveModulesis only offered for code-splitting formats, and AMD options are only offered for AMD and UMD formats.The name of each option can be clicked to get a direct link to the documentation. So this allows to play around with many different options to get a feeling for them. It also allows us to get reproductions for issues involving options.
What is not supported is function-valued options and plugins as I am currently unsure if we should allow to embed arbitrary code in the REPL. But maybe if we move bundling into a worker later, we could also think about that as then, function options can no longer modify the DOM when executed.