fix: export rollup.defineConfig at runtime#4134
Merged
Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install mshrtsr/rollup#fix/export-defineConfigor load it into the REPL: |
rollup.defineConfig at Node.js runtimerollup.defineConfig at runtime
lukastaegert
approved these changes
Jun 8, 2021
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Thanks, and ouch, this was really a mess. Reminds me why we usually test like mad...
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
rollup.defineConfigisundefinedat runtime. #4133Description
This PR fixes #4133.
I expose
defineConfigfrom entrypoint(node-entry.ts, browser-entry.ts).As a result, type definition and runtime correspond.