perf: User Map to optimize performance#4122
Merged
lukastaegert merged 2 commits intoJun 6, 2021
Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install izevo/rollup#perf-traceMappings-nameIndexMapor load it into the REPL: |
lukastaegert
approved these changes
Jun 6, 2021
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Great find, thanks a lot!
lukastaegert
requested changes
Jun 6, 2021
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Ah, it. seems a lot of tests are broken by this change. Could you have a look?
b4abfa2 to
ab9ad57
Compare
Contributor
Author
|
My mistake. I created a bug and it is fixed now. |
lukastaegert
approved these changes
Jun 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
Description
Use Map to optimize performance of traceMappings.
Before:
After:
