JsonSerializer does not respect Culture when deserializing primitive types#1606
Merged
alexeyzimarev merged 1 commit intorestsharp:devfrom Jul 15, 2021
Merged
JsonSerializer does not respect Culture when deserializing primitive types#1606alexeyzimarev merged 1 commit intorestsharp:devfrom
alexeyzimarev merged 1 commit intorestsharp:devfrom
Conversation
This was referenced Nov 8, 2025
This was referenced Dec 17, 2025
This was referenced Jan 13, 2026
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When deserializing any primitive type (floating point types especially), the JsonSerializer uses Convert.ChangeValue without passing Culture property, which results in using CurrentCulture as default.
I don't seem to find any other effective way how to enforce the RestSharp to deserialize primitive value using using custom Culture.
Purpose
This pull request is a:
Checklist