Double uppercase issue#1601
Merged
alexeyzimarev merged 2 commits intorestsharp:devfrom Jul 15, 2021
shipsaw:double_uppercase_issue
Merged
Double uppercase issue#1601alexeyzimarev merged 2 commits intorestsharp:devfrom shipsaw:double_uppercase_issue
alexeyzimarev merged 2 commits intorestsharp:devfrom
shipsaw:double_uppercase_issue
Conversation
This was referenced Nov 8, 2025
This was referenced Dec 17, 2025
This was referenced Jan 13, 2026
This was referenced Mar 5, 2026
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses an issue brought up in #1471 where attributes that ended in "ID" (or any sequence of upper-case letters) was not able to match with properties where those two letters were also both capitalized (i.e. "id", "Id"). I didn't see in the docs that case-insensitive matching was a requirement, but for many people it seems that it is implied.
Addressing this issue in the GetNameVariants method in StringExtensions.cs would seem to involve a lot of extra methods just to achieve a case-insensitive comparison, so I updated the Map method to create a new case-insensitive dictionary rather than simply referencing the previous one.
Purpose
This pull request is a:
Checklist