[e2e] [printer] Fix short open tag mixed php+html cause surplus <?php #3395
Merged
samsonasik merged 8 commits intomainfrom Feb 21, 2023
Merged
[e2e] [printer] Fix short open tag mixed php+html cause surplus <?php #3395samsonasik merged 8 commits intomainfrom
samsonasik merged 8 commits intomainfrom
Conversation
700efc5 to
a473789
Compare
Member
Author
|
Fixed 🎉 /cc @bananastalktome |
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
…nt is actually changed to different Stmt and ensure no invalid reprint that cause surplus <?php before <?= on short tag
Member
Author
|
@TomasVotruba I am merging it ;) |
|
@samsonasik Thank you! I can confirm that this fixes the issue I had in rectorphp/rector#7789 . |
Member
Author
|
@bananastalktome thank you for verify it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#7789
Ref https://getrector.com/demo/a27a9525-7cb7-49dc-bea4-0fbd52c29e2c