[Printer][EarlyReturn] Enable InlineHTML on RemoveAlwaysElseRector#3387
Merged
samsonasik merged 10 commits intomainfrom Feb 16, 2023
Merged
[Printer][EarlyReturn] Enable InlineHTML on RemoveAlwaysElseRector#3387samsonasik merged 10 commits intomainfrom
samsonasik merged 10 commits intomainfrom
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Member
Author
|
@TomasVotruba I am merging it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we skipped the
RemoveAlwaysElseRectorwithInlineHTMLexists inElse_part at PR:which skipped due to previous Stmt just removed so it has different parent Node with original Node. This PR enable it to allow
InlineHTMLonElse_part which just removed./cc @kkmuffme