Skip to content

[Php81] Handle null defined in variable first on NullToStrictStringFuncCallArgRector#3385

Merged
TomasVotruba merged 3 commits intomainfrom
null-defined-in-variable-first
Feb 15, 2023
Merged

[Php81] Handle null defined in variable first on NullToStrictStringFuncCallArgRector#3385
TomasVotruba merged 3 commits intomainfrom
null-defined-in-variable-first

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Feb 15, 2023

This is discovered by:

On variable defined to null early.

Fixes rectorphp/rector#7775

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 5db390c into main Feb 15, 2023
@TomasVotruba
Copy link
Copy Markdown
Member

Thanks 👍

@TomasVotruba TomasVotruba deleted the null-defined-in-variable-first branch February 15, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of SimplifyUselessVariableRector

2 participants