[Renaming][PostRector] Handle skip path after defined at RenameClassRector#3243
Merged
TomasVotruba merged 3 commits intomainfrom Jan 18, 2023
Merged
Conversation
Member
Author
|
Fixed 🎉 /cc @grandmaster44 |
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
7cd9e3c to
f5c8ac0
Compare
Member
Author
|
Rebased. |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
|
Thank you 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the following config in tests:
It not properly skipped, as there are 2 services:
The
ClassRenamingPostRectorapply the change already before it actually skipped because that read the configs:rector-src/packages/PostRector/Rector/ClassRenamingPostRector.php
Lines 27 to 35 in 3c168f0
This PR try to fix it with add new interface:
PostRectorDependencyInterfaceto define the dependencies of the PostRector when needed.Fixes rectorphp/rector#7417