Skip to content

[CodeQuality][TypeDeclaration] Handle default value from constructor removed on InlineConstructorDefaultToPropertyRector+TypedPropertyFromStrictConstructorRector #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 3 commits into from
Dec 20, 2022
Merged

[CodeQuality][TypeDeclaration] Handle default value from constructor removed on InlineConstructorDefaultToPropertyRector+TypedPropertyFromStrictConstructorRector #3225

TomasVotruba merged 3 commits into from
Dec 20, 2022

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 20, 2022 •
edited
Loading

Given the following code:

final class Fixture
{
    private $url;

    public function __construct()
    {
        $this->url = 'https://website.tld';
    }
}

The moved value from constructor assign should not be removed, ref https://getrector.org/demo/082ad859-87da-4222-bc3f-b50bc1b3c101

Current diff:

-    private $url;
+    private string $url;

Expected diff:

-    private $url;
+    private string $url = 'https://website.tld';

Applied rules:

- Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector
- Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector

@samsonasik
[CodeQuality][TypeDeclaration] Handle default value from constructor …
8f108ca 
…removed on InlineConstructorDefaultToPropertyRector+TypedPropertyFromStrictConstructorRector
@samsonasik
Copy link
Member Author

samsonasik commented Dec 20, 2022

Fixed 🎉 /cc @stefantalen

@samsonasik
Copy link
Member Author

samsonasik commented Dec 20, 2022

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 20, 2022

Thank you 👏

@TomasVotruba TomasVotruba merged commit bb8dedd into main Dec 20, 2022
@TomasVotruba TomasVotruba deleted the handle-inline-typed-default-value branch December 20, 2022 17:20
@samsonasik samsonasik mentioned this pull request Dec 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samsonasik @TomasVotruba @actions-user