[Core] Performance improvement: Remove unnecessary re-call FileFactory::createFileInfosFromPaths() #3210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y::createFileInfosFromPaths()
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Member
|
Nice catch: 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already initialization early in
ApplicationFileProcessor::run()rector-src/src/Application/ApplicationFileProcessor.php
Lines 63 to 65 in f2e4da5
so, internal call:
inside
createFromPaths()method no longer needed, as it can just consume existing defined initialization$fileInfosstring array data.It only happen on non-parallel configuration.
so:
✔️ Remove double Loop (only once at initialization already)
✔️ Remove double run clear cache
✔️ Remove double method call internally.