Skip to content

[DeadCode] Skip standalone @return false or true on RemoveUselessReturnTagRector #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 5 commits into from
Dec 15, 2022
Merged

[DeadCode] Skip standalone @return false or true on RemoveUselessReturnTagRector #3202

samsonasik merged 5 commits into from
Dec 15, 2022

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 15, 2022

The following code should be skipped:

final class SkipReturnStandaloneTrueFalseByReturnBool
{
    /**
     * @return true
     */
    function someTrue(): bool
    {
        return true;
    }

    /**
     * @return false
     */
    function someFalse(): bool
    {
        return false;
    }
}

Ref https://phpstan.org/r/6fbad07c-4b5e-4d89-8970-03df898abc6e

@samsonasik
Copy link
Member Author

samsonasik commented Dec 15, 2022

Fixed 🎉

@samsonasik samsonasik merged commit 0d6234b into main Dec 15, 2022
@samsonasik samsonasik deleted the skip-standalone-return-false-true branch December 15, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samsonasik @TomasVotruba @actions-user