Skip to content

[Php82] Handle parent already readonly on ReadOnlyClassRector #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 4 commits into from
Dec 14, 2022
Merged

[Php82] Handle parent already readonly on ReadOnlyClassRector #3199

TomasVotruba merged 4 commits into from
Dec 14, 2022

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 14, 2022

If parent class already readonly, child (current class analyzed) must be readonly too, ref https://3v4l.org/D9N7A

Fixes rectorphp/rector#7665

@samsonasik
Copy link
Member Author

samsonasik commented Dec 14, 2022

Fixed 🎉 /cc @kevariable

@samsonasik
Copy link
Member Author

samsonasik commented Dec 14, 2022

All checks have passed 🎉 @TomasVotruba it is ready for review.

@kevariable
Copy link

kevariable commented Dec 14, 2022

Thank you for the great work @samsonasik

@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 14, 2022

Thanks 👍

@TomasVotruba TomasVotruba merged commit be3bdd0 into main Dec 14, 2022
@TomasVotruba TomasVotruba deleted the handle-readonly-parent-already-readonly branch December 14, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Child non-readonly class doesnt refactor it into readonly when the parent was readonly class

4 participants

@samsonasik @kevariable @TomasVotruba