Skip to content

[Php73] Add closure bindings for SimplifyForeachToArrayFilterRector. #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 1 commit into from
Dec 3, 2022
Merged

[Php73] Add closure bindings for SimplifyForeachToArrayFilterRector. #3146

TomasVotruba merged 1 commit into from
Dec 3, 2022

Conversation

@Wohlie
Copy link
Contributor

@Wohlie Wohlie commented Dec 3, 2022

@Wohlie Wohlie requested a review from TomasVotruba as a code owner December 3, 2022 11:41
@samsonasik
Copy link
Member

samsonasik commented Dec 3, 2022

Could you fix the tests as well? disableImportNames() can be replaced with importNames(false, false)

@samsonasik
Copy link
Member

samsonasik commented Dec 3, 2022

@Wohlie I create PR

to fix test error, please rebase after that PR merged.

@samsonasik
Copy link
Member

samsonasik commented Dec 3, 2022

Please rebase

@Wohlie Wohlie force-pushed the fix-add-closure-bindings-on-foreach-to-array-filter-rector branch from 6bace60 to 48b1f53 Compare December 3, 2022 12:43
@Wohlie Wohlie force-pushed the fix-add-closure-bindings-on-foreach-to-array-filter-rector branch from 48b1f53 to 06057ca Compare December 3, 2022 12:45
@TomasVotruba TomasVotruba merged commit 21574dc into rectorphp:main Dec 3, 2022
@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 3, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of SimplifyForeachToArrayFilterRector

3 participants

@Wohlie @samsonasik @TomasVotruba