Fix type error on downgraded version. #2946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Sep 21, 2022
caf433c to
c78aa97
Compare
samsonasik
approved these changes
Sep 22, 2022
Member
samsonasik
left a comment
There was a problem hiding this comment.
The real bug possibly came from DowngradeUnionTypeDeclarationRector:
but this can be the solution for now while we can create a real patch in different PR for the use case like this
I am ok with this 👍
Member
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the downgraded version create a fatal error for
RemoveDeadInstanceOfRector:https://getrector.org/demo/fdba3d0f-4f97-4d01-9512-9dd71cb6730a
Because the type of
null|array|If_will be converted to?arrayforprocessMayDeadInstanceOf.This is just a quick fix, but I think on downgrades the real type should be used and not the doc types. But maybe the type came from PhpStan, I don't know.