[AutoImport] Skip multiple namespaces on single file on auto imports #2940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It seems cause error in test: There was 1 failure:
1) Rector\Tests\CodingStyle\Rector\Namespace_\ImportFullyQualifiedNamesRector\ImportFullyQualifiedNamesRectorTest::test with data set #10 ('/home/runner/work/rector-src/...hp.inc')
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
<?php
namespace {
- use function SomeNamespace\gc_disable;
function run_me_never()
{
// silent deprecations, since we test them
@@ @@
error_reporting(E_ALL ^ E_DEPRECATED);
// performance boost
- gc_disable();
+ \SomeNamespace\gc_disable();
}
}The issue is when importing is flipped to 2nd namespace instead of 1st namespace. I think it should just be skipped, then it will be safe. |
Member
Author
|
I updated the fixture to skip multiple namespaces |
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
TomasVotruba
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File with multiple namespaces currently make infinite loop on
UseAddingPostRector's PostRector.This PR skip it to avoid infinite loop due to somehow lookup on the
Fileinstead of current namespace.