Skip to content

[Php80] Handle crash on Nested Annotation to Attribute setting PhpVersion::PHP_80 (initializer - 1) #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 6 commits into from
Sep 15, 2022
Merged

[Php80] Handle crash on Nested Annotation to Attribute setting PhpVersion::PHP_80 (initializer - 1) #2929

TomasVotruba merged 6 commits into from
Sep 15, 2022

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 15, 2022 •
edited
Loading

Given the following code:

final class SkipNestedInPhp80
{
    /**
     * @Assert\All({
     *     @Assert\Uuid()
     * })
     */
    public array $selected = [];
}

with set config for PhpVersionFeature::NEW_INITIALIZERS - 1 or Phpversion::PHP_80

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig->phpVersion(PhpVersionFeature::NEW_INITIALIZERS - 1);

    $rectorConfig->ruleWithConfiguration(AnnotationToAttributeRector::class, [
        new AnnotationToAttribute(All::class),
    ]);
};

It currently cause crash:

There was 1 error:

1) Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Php80NestedAttributesRectorTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc')
TypeError: PhpParser\Node\Expr\ArrayItem::__construct(): Argument #1 ($value) must be of type PhpParser\Node\Expr, string given, called in /Users/samsonasik/www/rector-src/packages/PhpAttribute/AnnotationToAttributeMapper/ArrayItemNodeAnnotationToAttributeMapper.php on line 63

Fixes rectorphp/rector#7480

@samsonasik
Copy link
Member Author

samsonasik commented Sep 15, 2022

Fixed 🎉 /cc @mkalkowski83 , it was tried to apply nested new initializer, while it only exists in php 8.1, if the config is set php version to php 8.0, it should be skipped.

@samsonasik
Copy link
Member Author

samsonasik commented Sep 15, 2022

All checks have passed 🎉 @TomasVotruba it is ready for review.

@mkalkowski83
Copy link

mkalkowski83 commented Sep 15, 2022

WOW! thank you for reaction so quickly 💪

@TomasVotruba TomasVotruba merged commit cec7701 into main Sep 15, 2022
@TomasVotruba TomasVotruba deleted the fix-7480 branch September 15, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error on parsing file

5 participants

@samsonasik @mkalkowski83 @TomasVotruba @actions-user