Skip to content

[Php74] Skip Nested ternary parenthesized multiline on ParenthesizeNestedTernaryRector #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 3 commits into from
Sep 3, 2022
Merged

[Php74] Skip Nested ternary parenthesized multiline on ParenthesizeNestedTernaryRector #2902

TomasVotruba merged 3 commits into from
Sep 3, 2022

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 3, 2022 •
edited
Loading

The following code should be skipped as else as ternary multiline already open and closed with parentheses.

function SkipNestedTernaryParenthesizedMultiline()
{
    is_dir('app')
        ? 'app'
        : (is_dir('vendor/app')
            ? 'vendor/app'
            : 'vendor/alternative');
}

@samsonasik
Copy link
Member Author

samsonasik commented Sep 3, 2022

Fixed 🎉

@samsonasik
Copy link
Member Author

samsonasik commented Sep 3, 2022

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit d3cab63 into main Sep 3, 2022
@TomasVotruba
Copy link
Member

TomasVotruba commented Sep 3, 2022

👍

@TomasVotruba TomasVotruba deleted the skip-nested-ternary-parenthesized-multiline branch September 3, 2022 09:33
@samsonasik samsonasik mentioned this pull request Sep 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba