Skip to content

[DX] Make tracy debug functions part of dev-only, so developers can use own debug style #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 1 commit into from
Aug 29, 2022
Merged

[DX] Make tracy debug functions part of dev-only, so developers can use own debug style #2848

TomasVotruba merged 1 commit into from
Aug 29, 2022

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Aug 29, 2022 •
edited
Loading

These functions should never be used as public API, as Tracy should not be enforced.

Each dev should is able to use their own functions and ways they're used to - Symfony debug, xdebug, Ray etc. 👍

@TomasVotruba TomasVotruba changed the title make debug functions part of core only, so devs can use their own local functions [DX] Make debug functions part of core only, so devs are not forced to tracy and can use own debug style Aug 29, 2022
@TomasVotruba TomasVotruba changed the title [DX] Make debug functions part of core only, so devs are not forced to tracy and can use own debug style [DX] Make debug functions and trcy part of dev deps, so devs can use own debug style Aug 29, 2022
@TomasVotruba TomasVotruba changed the title [DX] Make debug functions and trcy part of dev deps, so devs can use own debug style [DX] Make tracy debug functions part of dev-only, so developers can use own debug style Aug 29, 2022
@TomasVotruba TomasVotruba enabled auto-merge (squash) August 29, 2022 16:38
@TomasVotruba TomasVotruba disabled auto-merge August 29, 2022 16:38
@TomasVotruba TomasVotruba merged commit 4176a64 into main Aug 29, 2022
@TomasVotruba TomasVotruba deleted the tv-less-debug branch August 29, 2022 16:38
samsonasik
samsonasik reviewed Aug 29, 2022
View reviewed changes
composer.json
"Rector\\Utils\\": "utils"
},
"files": [
"src/functions/node_helper.php",
Copy link
Member

@samsonasik samsonasik Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/functions can be removed from downgrade workflow

rector-src/.github/workflows/build_scoped_rector.yaml

Line 55 in 4765d5a

- run: bin/rector process src/functions vendor/symfony/string/Resources/functions.php -c build/config/config-downgrade.php --ansi

Copy link
Member Author

@TomasVotruba TomasVotruba Aug 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in main 👍 Thanks 🙂

Copy link
Member

@samsonasik samsonasik Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor/symfony/string/Resources/functions.php is needed to executed early

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Aug 29, 2022

Side effect of this cleanup is 7000 lines less in the shipped in every Rector install 🥳

image

@samsonasik
Copy link
Member

samsonasik commented Aug 29, 2022

@TomasVotruba I think in our rector-* extensions, we need to have debugger tool, if it goes to require-dev, then they need to have it in the require-dev as wel?

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Aug 29, 2022 •
edited
Loading

Yes, you can the tracy there if/when you need it.

@samsonasik
Copy link
Member

samsonasik commented Aug 29, 2022

To avoid repetitive create a debug_functions.php, I think we need to have a new repository intead, eg: rector-debugging which contains debug_functions.php content and if there is addition, we can add there instead of update to all repository, then finally, we can require --dev rector/rector-debugging in every repos, wdyt?

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Aug 29, 2022

That could a way to go 👍

@samsonasik
Copy link
Member

samsonasik commented Aug 29, 2022

Ok, I create a repository for it https://github.com/rectorphp/rector-debugging

@samsonasik
Copy link
Member

samsonasik commented Aug 29, 2022

I create init repo PR for it https://github.com/rectorphp/rector-debugging/pull/1

@samsonasik samsonasik mentioned this pull request Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomasVotruba @samsonasik