Skip to content

[AutoImport] Handle auto import crash on docblock @SuppressWarnings(PHPMD.ElseExpression) inside anonymous class #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 4 commits into from
Aug 20, 2022
Merged

[AutoImport] Handle auto import crash on docblock @SuppressWarnings(PHPMD.ElseExpression) inside anonymous class #2808

TomasVotruba merged 4 commits into from
Aug 20, 2022

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Aug 19, 2022

Given the following code :

return new class {
    /**
     * Run the migrations.
     *
     * @SuppressWarnings(PHPMD.ElseExpression)
     */
    public function up(): void
    {
        Schema::create('tagging_tagged', function (Blueprint $table) : void {
            $table->engine = 'InnoDB';
        });
    }
};

It currently produce error:

There was 1 error:

1) Rector\Tests\CodingStyle\Rector\Closure\StaticClosureRector\AutoImportTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Undefined array key "AnonymousClass11f5dd862c2eabeab7ceede0c3d39eca"

/Users/samsonasik/www/rector-src/vendor/nette/utils/src/Utils/Reflection.php:311
/Users/samsonasik/www/rector-src/vendor/nette/utils/src/Utils/Reflection.php:279
/Users/samsonasik/www/rector-src/rules/CodingStyle/ClassNameImport/ShortNameResolver.php:232

Fixes rectorphp/rector#7398

@samsonasik
Copy link
Member Author

samsonasik commented Aug 19, 2022

Fixed 🎉 /cc @Magiczne

@Magiczne
Copy link

Magiczne commented Aug 19, 2022

Thanks a lot!

@samsonasik
Copy link
Member Author

samsonasik commented Aug 19, 2022

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit e155e52 into main Aug 20, 2022
@TomasVotruba TomasVotruba deleted the handle-crash-anonymous-class-auto-import branch August 20, 2022 09:46
@TomasVotruba
Copy link
Member

TomasVotruba commented Aug 20, 2022

Thanks 👍

@samsonasik samsonasik mentioned this pull request Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Could not process file with anonymous class and phpmd SupressWarnings annotation

5 participants

@samsonasik @Magiczne @TomasVotruba @actions-user