Skip to content

[build] Separate publish build on several jobs#2379

Merged
violetagg merged 3 commits into1.0.xfrom
publish-separate-jobs
Jul 13, 2022
Merged

[build] Separate publish build on several jobs#2379
violetagg merged 3 commits into1.0.xfrom
publish-separate-jobs

Conversation

@violetagg
Copy link
Copy Markdown
Member

No description provided.

@violetagg violetagg added the type/chore A task not related to code (build, formatting, process, ...) label Jul 13, 2022
@violetagg violetagg added this to the 1.0.22 milestone Jul 13, 2022
@violetagg violetagg requested a review from simonbasle July 13, 2022 08:46
@violetagg
Copy link
Copy Markdown
Member Author

@simonbasle PTAL

Copy link
Copy Markdown
Contributor

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like an easy path to parallelize the testing phase 👍 suggested a few improvements inline

Comment thread .github/workflows/publish.yml Outdated
Comment thread .github/workflows/publish.yml Outdated
Comment thread .github/workflows/publish.yml Outdated
pderop
pderop previously approved these changes Jul 13, 2022
Copy link
Copy Markdown
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pderop pderop dismissed their stale review July 13, 2022 09:48

Dismissing my approval, since I was not asked to review this PR.

@violetagg
Copy link
Copy Markdown
Member Author

@pderop @simonbasle Thanks

@violetagg violetagg merged commit 71d0c28 into 1.0.x Jul 13, 2022
@violetagg violetagg deleted the publish-separate-jobs branch July 13, 2022 11:50
violetagg added a commit that referenced this pull request Jul 13, 2022
violetagg added a commit that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/chore A task not related to code (build, formatting, process, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants