Add onErrorComplete operator and rework onErrorReturn#3159
Merged
simonbasle merged 5 commits into3.4.xfrom Aug 29, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new implementation that optimizes the onErrorReturn case to avoid going through a generated
Publisher.Additionally, this implementation can easily accept a
nullfallback value, which covers a common case that has since now been covered byonErrorResume(e -> Mono.empty()).We take that as an opportunity to introduce a convenient
onErrorCompleteoperator for that later case.