ensures onLastAssembly does not break fusion chain#3156
Merged
OlegDokuka merged 3 commits into3.4.xfrom Aug 16, 2022
Merged
Conversation
Signed-off-by: OlegDokuka <odokuka@vmware.com>
added 2 commits
August 16, 2022 14:42
Signed-off-by: OlegDokuka <odokuka@vmware.com>
Signed-off-by: OlegDokuka <odokuka@vmware.com>
simonbasle
approved these changes
Aug 16, 2022
Contributor
|
@OlegDokuka there's 2 usages of |
Contributor
Author
Yes, looks like fusión is always off for parallel Flux and already using Hide subscriber |
|
@OlegDokuka this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
OlegDokuka
pushed a commit
that referenced
this pull request
Aug 16, 2022
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: OlegDokuka <odokuka@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3137
as it was observed,
onLastOperatormay add extra operators to the chain. In the case of scalar fusion at flatMap operators ( https://github.com/reactor/reactor-core/blob/main/reactor-core/src/main/java/reactor/core/publisher/FluxFlatMap.java#L118) the inner chain may be fused with the outer downstream. SinceonLastOperatormust be applied to the inner chain, modification added by the call may break fusion which leads to theClastCastExceptionSigned-off-by: OlegDokuka odokuka@vmware.com