adds cancellation of the source future support#3146
Merged
OlegDokuka merged 3 commits into3.4.xfrom Aug 15, 2022
Merged
Conversation
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: OlegDokuka <odokuka@vmware.com>
chemicL
approved these changes
Aug 10, 2022
added 2 commits
August 10, 2022 13:34
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: OlegDokuka <odokuka@vmware.com>
simonbasle
approved these changes
Aug 11, 2022
Contributor
simonbasle
left a comment
There was a problem hiding this comment.
this will likely cause some conflict when merging into main, but not too hard to solve. feel free to merge this @OlegDokuka 👍
|
@OlegDokuka this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
Contributor
|
merged into |
|
I believe the |
Contributor
that's a good point 👍 |
OlegDokuka
added a commit
that referenced
this pull request
Oct 28, 2022
this commits fixes misleading documentation introduced after #3146. Also, this commit adds extra methods overloads which allow suppression of the cancellation propagation to the observed `Future`
chemicL
pushed a commit
that referenced
this pull request
Mar 7, 2023
this commits fixes misleading documentation introduced after #3146. Also, this commit adds extra methods overloads which allow suppression of the cancellation propagation to the observed `Future`
This was referenced May 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3138
Signed-off-by: Oleh Dokuka odokuka@vmware.com